2581 update messages pallet to support intents #2616

JoeCap08055 · 2025-09-30T15:17:48Z

Goal

The goal of this PR is to migrate the messages pallet to add schema_id to message storage, and use intent_id as the index instead.

Existing index values do not need to be changed, as the schemas pallet migration ensures that the chain is seeded with Intent IDs that match existing Schema IDs

Related to #2581

Checklist

codecov · 2025-09-30T15:31:56Z

Codecov Report

❌ Patch coverage is 78.59779% with 58 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pallets/messages/src/types.rs	54.43%	36 Missing ⚠️
common/primitives/src/messages.rs	0.00%	13 Missing ⚠️
common/primitives/src/cid.rs	92.68%	6 Missing ⚠️
pallets/messages/src/migration/v3.rs	97.26%	2 Missing ⚠️
pallets/messages/src/migration/v2/mod.rs	50.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
pallets/messages/src/lib.rs	`91.72% <100.00%> (ø)`
pallets/messages/src/rpc/src/lib.rs	`96.07% <100.00%> (ø)`
pallets/messages/src/migration/v2/mod.rs	`50.00% <50.00%> (ø)`
pallets/messages/src/migration/v3.rs	`97.26% <97.26%> (ø)`
common/primitives/src/cid.rs	`92.68% <92.68%> (ø)`
common/primitives/src/messages.rs	`92.54% <0.00%> (ø)`
pallets/messages/src/types.rs	`58.06% <54.43%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoeCap08055 · 2025-09-30T17:20:36Z

Makefile

Made the following enhancements for try-runtime-* targets:

Only build the runtime, not the entire node; speeds up the build

Consolidate targets using patterns to avoid duplicated targets/commands

Fetch state for a minimal set of system pallets so that multi-block migrations can be properly tested

Allow the use of the PALLETS env var to specify additional pallets for dumping/restoring state

JoeCap08055 · 2025-09-30T17:25:10Z

pallets/messages/src/rpc/src/tests/mod.rs

Revert types here; need to remain compatible with existing custom RPC

JoeCap08055 · 2025-09-30T17:27:25Z

pallets/messages/src/tests/mock.rs

-	// Max payload size was picked specifically to be large enough to accommodate
-	// a CIDv1 using SHA2-256, but too small to accommodate CIDv1 w/SHA2-512.
-	// This is purely so that we can test the error condition. Real world configuration
-	// should have this set large enough to accommodate the largest possible CID.
-	// Take care when adding new tests for on-chain (not IPFS) messages that the payload
-	// is not too big.


This was an erroneous assumption. Since the configured value would never be this small on mainnet or testnet, it's better to allow a CIDv1/SHA2-512 by size, and have it fail for CID validation instead of for size reasons.

JoeCap08055 · 2025-09-30T17:29:09Z

pallets/messages/src/tests/other_tests.rs

 /// Helper function to generate message payloads
 ///
 /// # Arguments
-/// * `num_items` - Number of message to include in payload


This seemed overly complicated--a payload is just an array of bytes; why all the JSON stuff?

JoeCap08055 · 2025-09-30T20:00:40Z

pallets/messages/src/lib.rs

+		let cid = Cid::read_bytes(&cid_b[..]).map_err(|_| Error::<T>::InvalidCid)?;
+		ensure!([SHA2_256, BLAKE3].contains(&cid.hash().code()), Error::<T>::InvalidCid);


When cleaning up the mocks for the tests, noticed that it was attempting to test failure to accept CIDv1 (SHA2-512) by setting the max payload length artificially small.

The more correct approach (and what was missing from the code, eclipsed by that artificial test scenario) is to reject any CIDs with an unsupported hash. DSNP supports ONLY SHA2-256 and Blake3.

This is cool, I should do that in Provider Context as well

And if you like, would you like to make similar changes for cid validation for msa pallet, since this is an enhancement nevertheless, might refactor some?

pallets/messages/src/migration/v2/mod.rs

saraswatpuneet · 2025-10-02T14:21:29Z

pallets/messages/src/lib.rs


+	/// Storage for messages
 	#[pallet::storage]
-	pub(super) type MessagesV2<T: Config> = StorageNMap<


nit: Might have to retain (if downstream consumers are tied to this state)

That would not be ideal; the number of keys is very large.
To my knowledge, this is only used in:

Gateway (content-watcher)

Possibly the Freesky content viewer tool that @wesbiggs built

I will file issues in both of these repos.

pallets/messages/src/types.rs

pallets/messages/src/migration/v3.rs

JoeCap08055 · 2025-10-02T17:37:05Z

common/primitives/src/cid.rs

This file is not really net-new; I just haven't merged from main in a while. I've added some additional consts, and moved the CID validation function and tests from the messages pallet.

JoeCap08055 added 4 commits September 18, 2025 16:56

first pass - update messages pallet for intent-based message storage

a6d28b4

feat: multi-block migration for messages pallet using pallet-migrations

d6a6a04

unit tests for migrations

df27cf9

formatting

5bc7941

github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Sep 30, 2025

JoeCap08055 commented Sep 30, 2025

View reviewed changes

fix: allow Blake3 hash for CIDv1

af595db

github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Sep 30, 2025

JoeCap08055 commented Sep 30, 2025

View reviewed changes

JoeCap08055 marked this pull request as ready for review September 30, 2025 20:06

JoeCap08055 requested a review from wilwade as a code owner September 30, 2025 20:06

github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Sep 30, 2025

format and README

30ef1d0

saraswatpuneet reviewed Oct 1, 2025

View reviewed changes

pallets/messages/src/migration/v2/mod.rs Show resolved Hide resolved

JoeCap08055 changed the title ~~2581 update messages and stateful storage pallets to support intents~~ 2581 update messages pallet to support intents Oct 1, 2025

saraswatpuneet reviewed Oct 2, 2025

View reviewed changes

pallets/messages/src/types.rs Show resolved Hide resolved

saraswatpuneet reviewed Oct 2, 2025

View reviewed changes

pallets/messages/src/migration/v3.rs Show resolved Hide resolved

PR comments

9d7e6a1

github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Oct 2, 2025

JoeCap08055 commented Oct 2, 2025

View reviewed changes

github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Oct 2, 2025

JoeCap08055 merged commit 8a4ff8c into feat/schemas-permissions-development Oct 9, 2025
29 of 32 checks passed

JoeCap08055 deleted the 2581-update-messages-and-stateful-storage-pallets-to-support-intents branch October 9, 2025 15:55

		let cid = Cid::read_bytes(&cid_b[..]).map_err(\|_\| Error::<T>::InvalidCid)?;
		ensure!([SHA2_256, BLAKE3].contains(&cid.hash().code()), Error::<T>::InvalidCid);

2581 update messages pallet to support intents #2616

2581 update messages pallet to support intents #2616

Uh oh!

Conversation

JoeCap08055 commented Sep 30, 2025

Goal

Checklist

Uh oh!

codecov bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saraswatpuneet Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Sep 30, 2025 •

edited

Loading

saraswatpuneet Oct 2, 2025 •

edited

Loading